search

martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
207 stars 182 forks source link

Variables are not set when CI is true #376

Closed fno2010 closed 1 year ago

fno2010 commented 1 year ago

This conditional branching will never be executed. Because when $(CI) is true, $(REQUIREMENTS_TXT) will be empty.

As a result, the $(python) and $(xml2rfc) variable will not be set:

https://github.com/ietf-wg-alto/draft-ietf-alto-oam-yang/actions/runs/4606191226/jobs/8139185691#step:6:13

cat draft-ietf-alto-oam-yang.md  | kramdown-rfc --v3 | lib/trace.sh draft-ietf-alto-oam-yang.xml -s venue  lib/add-note.py | lib/trace.sh draft-ietf-alto-oam-yang.xml -s v2v3  --v2v3 /dev/stdin -o /dev/stdout >draft-ietf-alto-oam-yang.xml
lib/trace.sh: line 28: --v2v3: command not found
martinthomson commented 1 year ago

Sorry about that. I've fixed it in fda1ebc