martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
207 stars 182 forks source link

Node.js 12 actions and `set-output` are deprecated #378

Closed jkunze closed 1 year ago

jkunze commented 1 year ago

I don't know if this is an issue for i-d-template, but I'm getting some warnings from the Update Editor's Copy workflow:

  1. Node.js 12 actions are deprecated.
  2. The set-output command is deprecated and will be disabled soon.

Is there a recommended way of handling this?

dwaite commented 1 year ago

There appear to have been fixes for this in the internet-draft-template repo with commit f39cb0 - perhap this would be resolved if you update the GitHub actions in your repository and try again?

jkunze commented 1 year ago

Thanks. I've run "Update generated files", which nicely corrected the out-of-date email addresses in CODEOWNERS. I'm now waiting on the IETF datatracker folks to see if my previous submission needs to be cleared out.

jkunze commented 1 year ago

So they cleared out the previous submission and I resubmitted. This time there were more warnings but overall the build was apparently successful. If the text below doesn't render, it is from this page: https://github.com/arks-org/arkspec/actions/runs/4800115835

Annotations

4 warnings

Publish New Draft VersionNode.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/cache@v2, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.Show less

Publish New Draft VersionNo files were found with the provided path: draft-*-[0-9][0-9].xml. No artifacts will be uploaded. Publish New Draft VersionThe set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/Show less Publish New Draft VersionThe set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/Show less

Annotations 4 warnings Publish New Draft Version Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/cache@v2, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Publish New Draft Version No files were found with the provided path: draft-*-[0-9][0-9].xml. No artifacts will be uploaded. Publish New Draft Version The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Publish New Draft Version The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

martinthomson commented 1 year ago

Running the file update action won't fix the actions because actions can't update actions without extra permissions. You'll need to do that manually, either by copying over the new files or by running make update-files (or make update-ci) in a clone of the repository.

jkunze commented 1 year ago

Great! I ran make update-files, which looks good far. Does this functionality replace what I found in .github/workflows/update.yml (maybe I should remove that file)?

martinthomson commented 1 year ago

update.yml is convenient for updating other stuff (like the readme and the codeowners file). Keep it if you want to use it.