search

martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
204 stars 180 forks source link

Running make locally fails - space in dir name #428

Closed yaronf closed 1 month ago

yaronf commented 5 months ago

On a Mac (but with "make" correctly installed)

git clone -q --depth 10  \
    -b main https://github.com/martinthomson/i-d-template lib
lib/venv.mk:233: warning: overriding recipe for target '/Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My'
lib/venv.mk:228: warning: ignoring old recipe for target '/Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My'
lib/venv.mk:233: warning: overriding recipe for target 'Drive/Home'
lib/venv.mk:228: warning: ignoring old recipe for target 'Drive/Home'
lib/venv.mk:233: warning: overriding recipe for target 'Dir'
lib/venv.mk:228: warning: ignoring old recipe for target 'Dir'
lib/venv.mk:273: warning: overriding recipe for target '/Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My'
lib/venv.mk:233: warning: ignoring old recipe for target '/Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My'
lib/venv.mk:273: warning: overriding recipe for target 'Drive/Home'
lib/venv.mk:233: warning: ignoring old recipe for target 'Drive/Home'
lib/venv.mk:273: warning: overriding recipe for target 'Dir'
lib/venv.mk:233: warning: ignoring old recipe for target 'Dir'
lib/venv.mk:272: *** mixed implicit and normal rules: deprecated syntax
make: Circular /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My <- /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My dependency dropped.
make: Circular Drive/Home <- /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My dependency dropped.
make: Circular Drive/Home <- Drive/Home dependency dropped.
make: Circular Dir <- /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My dependency dropped.
make: Circular Dir <- Drive/Home dependency dropped.
make: Circular Dir <- Dir dependency dropped.
make: Circular 2022-8/misc/JOSE-COSE-Guidance/lib/.venv/bin/.initialized-with-Makefile.venv <- /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My dependency dropped.
make: Circular 2022-8/misc/JOSE-COSE-Guidance/lib/.venv/bin/.initialized-with-Makefile.venv <- Drive/Home dependency dropped.
make: Circular 2022-8/misc/JOSE-COSE-Guidance/lib/.venv/bin/.initialized-with-Makefile.venv <- Dir dependency dropped.
python3 -m venv /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My Drive/Home Dir 2022-8/misc/JOSE-COSE-Guidance/lib/.venv
/Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My Drive/Home Dir 2022-8/misc/JOSE-COSE-Guidance/lib/.venv/bin/python -m pip install  --upgrade pip setuptools wheel
bash: /Users/ysheffer/Library/CloudStorage/GoogleDrive-yaron_sheffer@intuit.com/My: No such file or directory
make: *** [lib/venv.mk:229: 2022-8/misc/JOSE-COSE-Guidance/lib/.venv/bin] Error 127

This is all very messy (and leaves several folders behind as it fails), but it looks like the root cause is a shell command that fails to handle a directory called "My Drive" somewhere up the tree.

yaronf commented 5 months ago

See https://github.com/sio/Makefile.venv/issues/5

martinthomson commented 2 months ago

@yaronf, I took a look at this. I've made some changes that mean that relative paths are used in makefiles. That made the ruby installation a massive pain, but I think that I have successfully sorted out most of the kinks. Let me know if this backfires.

yaronf commented 1 month ago

@martinthomson Works like magic, thanks!

martinthomson commented 1 month ago

That's because it is :) I'm happy that it worked out.