martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
208 stars 182 forks source link

`tool_install` installs tool executable but does not mark it executable #439

Closed aj-stein-nist closed 1 month ago

aj-stein-nist commented 1 month ago

Hello, I frequently use the Docker container locally, not just in GitHub Actions, for local development and review of documents. What a great tool, thanks for your efforts. I noticed that, even though idnits is installed correctly through the Dockerfile and the inline tool_install function, unlike the install function it does not make the resulting tool executable. Of course, manually using chmod +x in the container fixes that, but I would like to push a fix upstream.

$ docker run -it -v $(pwd):/app --entrypoint /bin/bash ghcr.io/martinthomson/i-d-template-math:latest
47701e80de0f:/app# cd /app
47701e80de0f:/app# make
47701e80de0f:/app# make check
echo versioned/draft-ietf-cbor-cddl-more-control-00.txt | xargs -n 1 sh -c 'lib/trace.sh "$0" -s idnits idnits "$0"'
lib/trace.sh: line 14: /usr/local/bin/idnits: Permission denied
lib/trace.sh: line 14: exec: /usr/local/bin/idnits: cannot execute: Permission denied
make: *** [lib/main.mk:148: idnits] Error 123

PR incoming, I will reference this issue.