search

martinthomson / i-d-template

A template for IETF internet draft git repositories
Other
208 stars 182 forks source link

Fix variable reference #443

Closed MikeBishop closed 2 weeks ago

MikeBishop commented 2 weeks ago

The variable $email doesn't appear to be defined, and this breaks. Changing it to $tagger appears to work, but I want to make sure I'm not breaking a different path.

martinthomson commented 2 weeks ago

Thanks Mike, easy error to fix, I hope.

MikeBishop commented 2 weeks ago

Looks like make upload finds the right thing now; I assume CI jobs won't pick up the change until the container image gets respun?

martinthomson commented 2 weeks ago

New action runs should pick up changes quickly. There might be some caching that means that new runs don't pick up things absolutely immediately, but I'd put that in the minutes category, not days.

pmeenan commented 2 weeks ago

Any chance this broke the publication to datatracker flow (or maybe it was relying on the failure before)?

I'm getting a 400 error from datatracker from the github action in the http-extensions repository that started today and the logs are showing {"error": "No such user: noreply@github.com"}.