martinthomson / ohttp

Rust library for encapsulating HTTP messages in a cryptographic wrapper
Apache License 2.0
22 stars 16 forks source link

Add support for X25519Kyber768Draft00 #49

Closed bwesterb closed 1 year ago

bwesterb commented 1 year ago

Maintainer of rust-hpke prefers to wait for the final version of Kyber, before including support. I'd understand if you'd like to hold of as well because of that.

Cf. https://datatracker.ietf.org/doc/draft-westerbaan-cfrg-hpke-xyber768d00/

cc @chris-wood

martinthomson commented 1 year ago

Hmm, this is a challenging one. I think that for something like this I'd want a feature flag. @bwesterb, do you think that you can manage that?

chris-wood commented 1 year ago

A feature flag is a good idea! Let's do that.

bwesterb commented 1 year ago

Very reasonable to expect a feature flag for that. Will change the PR.

bwesterb commented 1 year ago

It's under a feature flag now. There is a bit more code duplication than I would like. Not sure if we can work around it — my Rust macro fu isn't that strong yet.