martinthomson / ohttp

Rust library for encapsulating HTTP messages in a cryptographic wrapper
Apache License 2.0
30 stars 23 forks source link

Construct `ClientRequest` from `&mut KeyConfig` #56

Closed DanGould closed 10 months ago

DanGould commented 10 months ago

ClientRequests are single use so one making multiple requests needs to use the KeyConfig multiple times. Making each one from a reference rather than an owned KeyConfig allows this.

edit: The CI errors appear to be from the new clippy version and do not have to do with this change

martinthomson commented 10 months ago

Thanks Dan, this makes sense.

Let me know if you would like me to cut a new release with this one. There are a few cleanup items to look into before I do that.

DanGould commented 10 months ago

It'd be great to get cut one but there's no pressure the way there was for KeyConfig to be Clone. I just had this change locally and figured I should upstream it.

Thanks for the quick turnaround