search

martinthomson / ohttp

Rust library for encapsulating HTTP messages in a cryptographic wrapper
Apache License 2.0
30 stars 23 forks source link

Test MSRV in CI #59

Closed martinthomson closed 10 months ago

martinthomson commented 10 months ago

Other projects use a matrix arrangement in their workflow file to ensure that the code continues to work on a set minimum rust version. Do that. We have a request for 1.63 as a minimum, though the actual minimum is probably lower right now. Work out what it is and make CI enforce that, so that any change to MSRV is deliberate.

DanGould commented 10 months ago

It turns out our MSRV is indeed 1.63 since our dependency in ohttp-client on request depends on socket2-0.5.3. Found it with binary search via cargo-msrv. I'm sure specific crates in this workspace have lower msrv but 1.63 works for me.