search

martintsai / ga-bewd-hw1

0 stars 0 forks source link

Should returns 404 when record not found #1

Open 3dd13 opened 10 years ago

3dd13 commented 10 years ago

there is a standard on how to use this status code

status 500 means server side error status 404 means record not found

martintsai commented 10 years ago

Hi Eddie,

Thanks for the suggestion and I changed the status code accordingly. BTW, I thought for a moment if I should just redirect to the generic /public/404.html page, but it felt more sensible to render a customised error page instead.

Martin

Martin Tsai, PhD Creaxon Limited 219A, Enterprise Place, 5 Science Park W. Ave, Shatin, Hong Kong Office: +852-3902-3100・Mobile: +852-9820-9680

On Mon, Dec 9, 2013 at 2:54 PM, 3dd13 notifications@github.com wrote:

there is a standard on how to use this status code

status 500 means server side error status 404 means record not found

— Reply to this email directly or view it on GitHubhttps://github.com/martintsai/ga-bewd-hw1/issues/1 .