search

martinvonz / jj

A Git-compatible VCS that is both simple and powerful
https://martinvonz.github.io/jj/
Apache License 2.0
7.34k stars 242 forks source link

FR: sign Windows pre-compiled binaries #3163

Open jyn514 opened 4 months ago

jyn514 commented 4 months ago

Is your feature request related to a problem? Please describe. Right now, installing from the github releases page instead of from source results in windows Defender blocking the executable:

ResourceUnavailable: Program 'jj.exe' failed to run: An error occurred trying to start process 'C:\Users\jyn\.cargo\bin\jj.exe' with working directory 'C:\Users\jyn\src\dotfiles'. Operation did not complete successfully because the file contains a virus or potentially unwanted software.At line:1 char:1

image

this is really annoying; not all my laptops have a rust compiler installed, and some are woefully underpowered.

Describe the solution you'd like sign the pre-compiled binaries so that windows defender doesn't block them.

Describe alternatives you've considered @steveklabnik suggested using cargo-dist to do this automatically. unfortunately, cargo-dist doesn't actually support signing binaries yet: https://github.com/axodotdev/cargo-dist/issues/21#issuecomment-1734474160

Additional context

MadelineRitchie commented 2 months ago

I am also unable to use jj at work because our corporate Windows Defender falsely identifies it as that trojan Win64/Malagent!MSR.