martinvonz / jj

A Git-compatible VCS that is both simple and powerful
https://martinvonz.github.io/jj/
Apache License 2.0
7.24k stars 240 forks source link

cli: rename `jj file print` (formerly `jj cat`) to `jj file show` #3966

Closed ilyagr closed 6 days ago

ilyagr commented 1 week ago

We now have two cmd_show in the repo. I think this one should become cmd_file_show, but this should be done uniformly over all the commands for consistency.

I did not keep print as an alias (I couldn't find a compelling reason to do it), but let me know if anyone feels like keeping it.

(This was discussed in https://github.com/martinvonz/jj/issues/3812. We should decide before the release next week whether or not to do this).

Checklist

If applicable:

ilyagr commented 6 days ago

I'll wait until tomorrow to merge, in case anyone has comments or requests to wait longer.

emilazy commented 6 days ago

Thank you for this! I dislike the programmer terminology of “print” to mean “show” or “write”. I don’t think it’s very clear in general, but I especially wouldn’t expect it for something that reads from a file rather than outputting a string directly. I think this will be more approachable for users and intuitive in light of jj show.

arxanas commented 6 days ago

I dislike the programmer terminology of “print” to mean “show” or “write”. I don’t think it’s very clear in general

agreed, no lpr(1) integration → NOT a print command 👏