martinvonz / jj

A Git-compatible VCS that is both simple and powerful
https://martinvonz.github.io/jj/
Apache License 2.0
7.24k stars 240 forks source link

fake-editor: replace expectpath with dump-path #3995

Closed mlcui-corp closed 1 day ago

mlcui-corp commented 2 days ago

This allows us to assert the expected path in the test itself, rather than in the fake editor.

(This will be used for when we de-UNC-ify invocations of the editor, see #3986 for more details.)

Checklist

If applicable:

mlcui-corp commented 2 days ago

expectpath is now not used anywhere - should we remove it in this PR?

mlcui-corp commented 1 day ago

Resolved comments - PTAL.