martinvonz / jj

A Git-compatible VCS that is both simple and powerful
https://martinvonz.github.io/jj/
Apache License 2.0
8.37k stars 287 forks source link

`jj git fetch` succeeds in pulling a non-existent branch name #4293

Closed rdamazio closed 2 weeks ago

rdamazio commented 1 month ago

Description

If I specify a non-existent branch name to jj git fetch, it doesn't fail.

Steps to Reproduce the Problem

  1. jj git clone https://github.com/rdamazio/efis-editor.git
  2. cd efis-editor
  3. jj git remote add zyv https://github.com/zyv/efis-editor.git
  4. jj git fetch -b features/foreflight-support --remote zyv (misspelled branch name)

Expected Behavior

It'd tell me that the branch I asked to fetch does not exist.

Actual Behavior

Nothing changed

Specifications

yuja commented 1 month ago

Perhaps, warning can be displayed if a branch glob doesn't match any of the changed or known remote branches.