martinvonz / jj

A Git-compatible VCS that is both simple and powerful
https://martinvonz.github.io/jj/
Apache License 2.0
8.32k stars 284 forks source link

split: do not prevent all changes from going into the parent commit, and a fix #4542

Closed samueltardieu closed 5 days ago

samueltardieu commented 6 days ago

Allowing to put everything into the first commit closes #4533.

Question: should we suggest using jj undo if everything was put into one of the two commits in case the user didn't want to do this? Or, do we want this only if, in addition, the empty commit has an empty description, because there should be no reason to create an empty commit?

Checklist

If applicable:

martinvonz commented 6 days ago

Should most of the PR description be moved into the commit description (with s/PR/commit/ or similar)? The question makes sense in the PR description.

samueltardieu commented 6 days ago

Should most of the PR description be moved into the commit description (with s/PR/commit/ or similar)? The question makes sense in the PR description.

It even led me to split the commits (using jj split, this is appropriate).