Git submodules not ignored - Githubissues

martinvonz / jj

A Git-compatible VCS that is both simple and powerful

https://martinvonz.github.io/jj/

Apache License 2.0

9.51k stars 325 forks source link

Git submodules not ignored #5005

Open istudyatuni opened 4 days ago

istudyatuni commented 4 days ago

Description

Changelog for v0.6.0 states that "Git submodules are now ignored completely", but that's not work (even on v0.6). Am I missing something?

Steps to Reproduce the Problem

jj git init --colocate
git submodule add https://github.com/martinvonz/jj
jj st

Expected Behavior

Only .gitmodules file is added

Actual Behavior

All files from submodule are also added

Specifications

Platform: Linux
Version: v0.12. Also tested on latest main (0ca6f00421f6f893e974e0f5349e126abd41a812 - Nov 30)

v0.6 tested with nix shell 'github:martinvonz/jj?ref=v0.6.0'

yuja commented 4 days ago

Submodule support is pretty minimal. You need to do git commit before the change is snapshotted by jj st.

All files from submodule also are added

Maybe we should ignore files in the nested repo, no matter if it is a submodule or not.