search

martipal / SoundBubble

This project is implemented as part of coursework for CPSC463I at the University of British Columbia. This project is intended for users who are subscribed to the music platform Spotify. It will allow users, and other users within their “Group”, to view each other’s song logs and interact with the logs by “Up Voting” or “Down Voting” a particular log. The type of data we will be storing are Songs along with User Information. This data will be able to be shared among users to access within the group. Additional functionality that we may add/remove based on time constraints is the ability to recommend a played song to another user, and adding commenting functionality to a particular song log for users to provide their opinions (e.g. “This song is awesome!”, “This song is lame”).
0 stars 2 forks source link

remove group bug fix #25

Closed Talos6 closed 5 years ago

Talos6 commented 5 years ago
  1. after leave or delete a group, the home page should be updated that not shown any none existed group
  2. fix by everytime leave or remove the group will reset the currentgroup process and call initialize by the home page components
veronicz commented 5 years ago

Currently, SongLog relies on currentGroup in redux. So when adding a group member, we should either update currentGroup in redux store, or we could add another subscription to SongLog and store only the groupId in redux. Which do you think is better?

Also just a suggestion, I think leaveGroup/deleteGroup should check if the group left/deleted is the current group before setting it to null. Since we have access to the current state and the groupId left/deleted, we could do a simple if check here in the action instead of letting GroupButton set the default group and trigger a bunch of re-rendering.