search

martius-lab / cluster_utils

https://cluster-utils.readthedocs.io/stable/
Other
12 stars 0 forks source link

Do not modify sys.argv inplace. #19

Closed luator closed 5 months ago

luator commented 1 year ago

This is bad practice.

See https://gitlab.tuebingen.mpg.de/mrolinek/cluster_utils/-/blob/master/cluster/settings.py#L247

By @mseitzer (imported from GitLab)

luator commented 11 months ago

I think the link above is not pointing to the correct line anymore. I guess the problem is here: https://gitlab.tuebingen.mpg.de/mrolinek/cluster_utils/-/blob/e9d0c86c86ff3021e1abcb048472a25617e6deba/cluster/settings.py#L324 (should copy instead of just assigning a reference)

By Felix Widmaier on 2023-11-28T14:34:33 (imported from GitLab)

mseitzer commented 5 months ago

Fixed by #104