martok / palefill

Inject Polyfills for various web technologies into pages requiring them
https://martok.github.io/palefill/
Mozilla Public License 2.0
81 stars 9 forks source link

GitHub: saved replies dropdown no longer loads #100

Closed jrfnl closed 3 months ago

jrfnl commented 8 months ago

Seems to be something which changed in the last few days (as I remember adding a new saved reply from the dropdown last week).

When I click on the "Saved replies" button, the following non-descript and useless error shows up in the console: image

martok commented 8 months ago

TIL: <dialog> elements. That's actually pretty useful, reminds me of something I wrote checks git 16 years ago 🤯

May want to do that in the platform...

AroKol78 commented 8 months ago

I don't know if it matters, but when I switch (dom.dialog_element.enabled) it, the the

elements examples work

jrfnl commented 8 months ago

I'll give dom.dialog_element.enabled a try and will let you know how I get on.

jrfnl commented 8 months ago

Hmm... sort of working, but not really...

image

Only shows the first 8 saved replies (I have more), doesn't show the "add new saved reply", doesn't allow scrolling the list.

Error is gone from Console though and no new errors showing up (even though it doesn't work as it should).

rofl0r commented 8 months ago

probably equally annoying is that i can't close issues anymore. js log shows "ReferenceError: PerformanceObserver is not defined"

jrfnl commented 8 months ago

@rofl0r Cricky.. I hadn't noticed that yet (haven't had to close an issue in the last two days) That IS terrible design by GH... Seriously, what happened to the age-old wisdom of graceful degradation ? Don't they teach that anymore to kids nowadays ?

jrfnl commented 8 months ago

Just saw Palemoon 33.0.0 was released and installed that, but not seeing improvements on this issue. Was worth a try anyway ;-)

rofl0r commented 8 months ago

btw i was able to fix that with dom.enable_performance_observer. rubberduck debugging at its finest.

AroKol78 commented 8 months ago

dom.dialog_element.enabled without this switch the account menu doesn't work and ... if I switch it, it displays miracles

Screenshot_x2 ![buggh0001](https://github.com/martok/palefill/assets/70756447/0d61e639-cbbf-4c70-9d79-1b9f7da16c5b) ![buggh0002](https://github.com/martok/palefill/assets/70756447/5d0b079c-e977-4f0e-b551-0a0c4b47d0b1)
martok commented 3 months ago

Fixed by PM 33.2, thanks to a lot of work by Moonchild 🎉