search

martok / palefill

Inject Polyfills for various web technologies into pages requiring them
https://martok.github.io/palefill/
Mozilla Public License 2.0
79 stars 9 forks source link

LICENSE #2

Closed SeaHOH closed 2 years ago

SeaHOH commented 2 years ago

Plz keep the infos of copyright together with your referred codes. https://github.com/martok/palefill/blob/56fdb09e5e7db8f7cf9895e730212fbd6ed23424/lib/polyfills.js#L175

SeaHOH commented 2 years ago

And the two are not the parts of attachShadow.

https://github.com/martok/palefill/blob/56fdb09e5e7db8f7cf9895e730212fbd6ed23424/lib/polyfills.js#L178 This origin is https://github.com/foobarhq/get-root-node-polyfill

https://github.com/martok/palefill/blob/56fdb09e5e7db8f7cf9895e730212fbd6ed23424/lib/polyfills.js#L199-L204

martok commented 2 years ago

Right, I need to take more care (especially now that people other than me use this :wink: ).

Should I credit you for the ShadowRoot and attachShadow polyfill, or is it based on something?

And yes, the "Load Diff" css fix was not supposed to stay there, I wanted to move that to a separate code block and forgot...

rofl0r commented 2 years ago

btw i currently hacked this plugin by replacing all occurences of github with some fantasy string, so it doesn't interfere with github-wc-polyfill. it might be advantageous for other users too to have a single knob to turn the duplicated functionality on or off.

martok commented 2 years ago

btw i currently hacked this plugin by replacing all occurences of github with some fantasy string, so it doesn't interfere with github-wc-polyfill. it might be advantageous for other users too to have a single knob to turn the duplicated functionality on or off.

This is something I've been avoiding for a while (even though this was the whole point of the rule engine design), seems I need to face it. Tracking as #3...

SeaHOH commented 2 years ago

Should I credit you for the ShadowRoot and attachShadow polyfill, or is it based on something?

The idea comes from @misteuk https://github.com/JustOff/github-wc-polyfill/pull/48 , and I expand it. Just do the same to e.g. copyright of Custom Elements you put in the front of polyfills.js, you can find it in the front of bootstrap.js. Also for JustOff, only put in README is not enough.

martok commented 2 years ago

Ok. I've pushed 7ecf7c83e, can you please have a look at it and let me know if everything is in the proper form? I don't want to misrepresent anything.

martok commented 2 years ago

Thanks for the comments. Maybe this will change in the future to "and contributors" or something, but for now I'm going to keep both instances as-is. Even if it might not be neccessary in the copyright sense, I'd still rather have everyone named just for giving proper credit.

I guess that resolves this. Thank you for reminding me to not be lazy.