martok / palefill

Inject Polyfills for various web technologies into pages requiring them
https://martok.github.io/palefill/
Mozilla Public License 2.0
79 stars 9 forks source link

GitHub "404" pages not being processed by palefill #26

Closed Vangelis66 closed 2 years ago

Vangelis66 commented 2 years ago

Browser version: Serpent 52.9.0 (2022-05-27)(32-bit) - includes support for "?."+"??" Extension version: Latest GitHub HEAD (v1.13-2-20220617-gdd0e0b5)

STR

  1. While being logged-in to your GitHub account, say you arrive on a "404" page, e.g.:

https://github.com/MoonchildProductions/moebius

  1. You soon become aware that on such a page, the palefill extension does NOT work its magic 😞 ... E.g., try to access your GH account's avatar button, on the top-right, to sign out/change an account setting, etc. Expected result: The familiar dropdown should open Actual result: The dropdown warns: "Sorry, something went wrong."

404gh2

Actually, this is a duplicate of an upstream issue I filed 3 1/2 months ago, https://github.com/JustOff/github-wc-polyfill/issues/55 that was successfully resolved by the then maintainer (SeaHOH) via https://github.com/JustOff/github-wc-polyfill/commit/801d240 (above commit also addressed an issue not related to the "404" one... 😉 ) It would appear that "fix" has not made it yet to palefill... A backport will be much appreciated! 😄

Vangelis66 commented 2 years ago

Thanks a bunch for the timely fix! 🎉 Current git HEAD (v1.13-4-git-20220619-g01beec4) works a treat 👍