Github: optional chaining (again)

martok / palefill

Inject Polyfills for various web technologies into pages requiring them

https://martok.github.io/palefill/

Mozilla Public License 2.0

79 stars 9 forks source link

Github: optional chaining (again) #5

Closed martok closed 2 years ago

martok commented 2 years ago

Github uses more optional chaining now:

19:19:11.200 SyntaxError: expected expression, got '?'[Learn More]  
8933-d8b0634d2391.js:49:2049
19:19:11.393 SyntaxError: expected expression, got '.'[Learn More]  
2403-3e07b8533bbd.js:1:7833
19:19:11.397 SyntaxError: expected expression, got '?'[Learn More]  
7253-67d624cbaf0c.js:1:10803

This currently breaks (at least) the editor preview tab.

martok commented 2 years ago

This did not get all of them, also some integrity overrides are missing.

rofl0r commented 2 years ago

nice, your addon currently works better than github-wc-polyfill... thanks!

martok commented 2 years ago

There are still some things that throw errors at runtime, but things seem to work... try 1.6b1 if you need a function that 1.5 missed (quite a few...).

I'm not very happy with the way it's resolved now, but hey... can't always get what you want.

Vangelis66 commented 2 years ago

FYI: https://github.com/JustOff/github-wc-polyfill/issues/58#issuecomment-1065789405

😄

martok commented 2 years ago

Oh bloody hell :rofl:

At least we learned what to do when it happens for real :roll_eyes:

dirkf commented 2 years ago

That seems to have happened now.