Vangelis66
commented
1 year ago NB: In
palefill-1.23+, "soft" navigation has been disabled
Some important follow-up regarding GitHub Soft Navigation inside palefill:
Because it is blocked by #50 (presumably an unidentified UXP bug),
SN was "temporarily" disabled in palefill via 5e1c7d8.
I have been conducting some "experiments" here 😜 , where I have re-enabled SN in palefill snapshots after v1.23 and then observed my browser's behaviour/RAM consumption (but that is not the subject of my comment)...
Deleting (or commenting out) code block (file ./lib/polyfills.js)
// TEMPORARY: hard-disable Turbo navigation to prevent memory leaks in Pale Moon
document.addEventListener("DOMContentLoaded", () => {
Turbo.session.elementIsNavigatable = (e) => false;
Turbo.session.formMode = "off";
Turbo.session.willFollowLinkToLocation = (l, ll, e) => false;
const FrameElement = document.createElement("turbo-frame").constructor;
FrameElement.delegateConstructor.prototype.shouldInterceptNavigation = (e, s=null) => false
});has always been enough to get back SN working in GH with palefill installed - always, until (and including) code snapshot palefill-v1.24-2-git-20221201-g2731460 that is...
Starting with recent snapshot palefill-v1.24-3-git-20221203-g395dbc6 (first BAD), removing the code block above to reinstate SN results in a palefill installation whereby GitHub Soft Navigation is completely broken everywhere on GitHub 😿 (original issue here was only about Actions tab); by the looks of it, while 395dbc6 successfully resolved #65 (👍 ), it must have inadvertently and "permanently" broken Soft Navigation 😞 ...
For the time being, I won't be submitting a New issue about this (unless instructed otherwise), but I'm posting this comment as a FYI if/when GH SN is revisited in the context of palefill ...
Kind regards.
SeaHOH
Browser: Serpent v52.9.0 (2022-08-24) (32-bit) Extension version:
palefill-1.22-3-git-20221016-g01a436b(the most recent snapshot where soft navigation (aka "turbo") isn't disabled)STR:
1st test:
<> Codetab should have been selected 😉 ...Actionstab; the blue line on top will start to move to the right very slowly, end result being:2nd test:
All workflowsvertical tab should have been selected...pages-build-deploymentvertical tab; result (as previously):DESCRIPTION: This has started happening just a few days ago, when MS started messing (again) with the
Actionstab 😡 (read from "them" here 😉 ) ; below is an excerpt fromWeb Console:I am by no means Javascript savvy, but my searching skills tell me it's most probably: https://github.com/microsoft/TypeScript/issues/40454 😞 UXP does have support for IntersectionObserver, first implemented in Fx55, but, as linked in the documentation, support for
options.rootother thanElementwas first implemented in Fx76...WORKAROUND: Blocking the culprit script in uBO offers a kludge:
NB: In
palefill-1.23+, "soft" navigation has been disabled, thus this issue has been "swept under the rug" 😜 ; but, Web/Error Consoles will still generate messages about the culprit script(s) 😠 ...