Update to PM 31.0 - Githubissues

martok / palefill

Inject Polyfills for various web technologies into pages requiring them

https://martok.github.io/palefill/

Mozilla Public License 2.0

79 stars 9 forks source link

Update to PM 31.0 #8

Closed martok closed 2 years ago

martok commented 2 years ago

[x] have optional Firefox GUID. Should be no change from our side as native PM/SM addon?
[x] queueMicrotask is implemented, remove polyfill
[x] optchaining implemented, remove scriptfixes (only ?., nullish coalescing ?? is implemented in upstream UXP, should be in next release)

martok commented 2 years ago

Help Wanted: someone with Seamonkey expertise, please clarify what that means for syntax hotpatching: do we need to carry the existing patches for the forseeable future? I'd like to remove fixes not needed for Goanna, but don't want to break SM for no reason.

martok commented 2 years ago

Postponing until hopefully a 31.x point release: the removal of one too many e10s flags (see https://repo.palemoon.org/MoonchildProductions/Pale-Moon/commit/deaeb6874dfe19e69ea2915d206c690735072de4) broke many of my daily-use addons so I can't really upgrade to 31. It's been fixed upstream so it probably won't be too long...

UCyborg commented 2 years ago

I wouldn't call myself SeaMonkey expert, but nothing new in the current stable version as far as new JavaScript syntax is concerned. If you think it'll speed anything up for Goanna, maybe wrap optional chaining patches in if (service.isSeaMonkey).

You can also probably remove the fix for Stack Exchange. I imagine if the issue pops up again, it'll be in some other place...few days ago optional chaining appeared inline of HTML of Stack Overflow website specifically, then disappeared at later point.

martok commented 2 years ago

Thanks. That actually gives me an idea, the new rule tree architecture is flexible and fast enough that I can just split the rule scripts in a generic and UA-specific one and decide at runtime which one to load and merge. No UA gates required in code then.

UXP has gotten Franklin's ?? implementation as well, so that'd be another load of fixes out for the next release. Which, with my luck, will be released right after I extend this addon to switch based on PM30/31+ :D

martok commented 2 years ago

Released 1.10 with PM31 support. Still need to clean up the required fixes... I have a good concept for how to do that with the different supported platforms now, just need to find the time to sit down and implement it.

ghost commented 2 years ago

It seems to work fine with Github on PM 31, but if I go to Gitlab it shows an endlessly spinning circle on the issues search box.

l29ah commented 2 years ago

It does not. File attachment functionality in the issue post/comment box doesn't work.

martok commented 2 years ago

@JAAnon @l29ah Please open a separate issue with steps to reproduce, works for me. (Well, the Gitlab average of "works"... I'll never understand why people love them so much)

l29ah commented 2 years ago

I was talking about github.

martok commented 2 years ago

monkeys

Hm. Works here but it might be some interaction, I'll check with a blank profile tomorrow!

-- Update: nope, can't see any problem in a fresh portable install either.

martok commented 2 years ago

I have a good concept for how to do that with the different supported platforms now, just need to find the time to sit down and implement it.

Aaaand done. Let's see how future proof it is (and also, what odd bugs I introduced :sweat_smile:)