search

martok / palefill

Inject Polyfills for various web technologies into pages requiring them
https://martok.github.io/palefill/
Mozilla Public License 2.0
81 stars 9 forks source link

GitHub: Discussions partially BROKEN #87

Closed Vangelis66 closed 1 year ago

Vangelis66 commented 1 year ago

Browser: Serpent 52.9.0 (2023-03-10) (32-bit) *NB: this specific build has, by default: 

dom.webcomponents.enabled;true
dom.getRootNode.enabled;true

to test the new upstream (MCP) implementation of Web Components; these default settings might conflict with the extension, so they have been both toggled to false. Extension version: code snapshot palefill-v1.26-6-git-20230204-g7d4e837

STR:

Not all GitHub repos have Discussions enabled (e.g., this one doesn't :wink:); but many do... So, e.g., navigate to:

https://github.com/orgs/Homebrew/discussions/4329

The page "appears" to load OK, but on closer inspection, several crucial parts of it don't load/work as in the rest of GitHub with the extension enabled: a) the "user profile" button is broken: b1 b) the ellipsis (...) "Discussion options" button in a post's top header is broken: b2 c) (which, for me, is the worst breakage 😞 ) the reply/comment/post editor is broken, i.e. trying to use any of its buttons doesn't produce the expected result; in the picture below, I'm trying to 'bold-ify" typed word test, to no avail: b3

Of course, if you master the markdown language by heart, you can mitigate this editor breakage, however 😜 ...

WebConsole reports some already known errors, e.g. 

TypeError: navigator.clipboard is undefined
RangeError: invalid value unit for option style

and, when using the editor, 

TypeError: t.dismiss is not a function

PS: The reason I myself still prefer palefill over the native WC implementation is a GH-relative-timestamps bug the latter exhibits, which, thankfully, is not the case with palefill 👍 ; more about that can be found here and here 😉 ...

EDIT: GH-relative-timestamps bug has been fixed via MoonchildProductions/UXP/commit/4c4bc3c, which arrived in Serpent 52.9.0 (2023-03-15) (32-bit) 👍 ...

Many thanks for your coding efforts :smile:, both here in the extension as well as the UXP platform in general 🥇 ...

Vangelis66 commented 1 year ago

... Advancements in the UXP platform itself have mitigated all reported issues in my OP from mid-March 👍 ...

Running currently Serpent 52.9.0 (2023-05-12) (32-bit) with palefill disabled and GitHub Discussions pages appear to function properly, in every aspect... Subject to break in the future, no doubt, as GitHub seem to be in an "update spree", pushing all sorts of UXP-incompatible code... But, for now at least, I'll be closing this issue 😉 ...

Thanks @martok for your UXP-improving contributions!