search

martomi / chiadog

A watch dog providing a peace in mind that your Chia farm is running smoothly 24/7.
MIT License
458 stars 120 forks source link

Add support for parsing partials and solo blocks #268

Closed kanasite closed 3 years ago

kanasite commented 3 years ago

Disabling proof notification (due to frequent partial alert), partials submitted added to daily stats, added specific block farmed parsing

martomi commented 3 years ago

@kanasite please also read the guide for contributors so that you can make the CI tests pass.

kanasite commented 3 years ago

guide for contributors

ah great, sorry I was adding these via vim and dint notice about the CI tests, will update it as soon as I can

kanasite commented 3 years ago

Thanks @kanasite, overall looks pretty good!

Let's remove unused and commented out parts of the code.

I'd like to also see some test coverage on the new parsers and handlers. Should be quite straightforward if you use the existing ones as a template.

I can't test this myself now, so it would be great to hear from other members of the community on that. Anyone already running this change?

I made some quick changes for the linting and also the feedbacks. For the test coverage, I probably will take a little longer to add when I have some time to spare

kanasite commented 3 years ago

Thanks for addressing the feedback @kanasite!

This one still needs attention: #268 (comment) Unless we revert the commit that I referenced there, it will still continue spamming Found Proof notifications.

Would be awesome If you get a chance to do the tests within the following few days. Worst case I will release without tests and they can be added in a follow-up PR.

Sorry I missed that out, I guess I will add the tests in a follow-up PR

mressler commented 3 years ago

I'm really looking forward to a release with this PR in it. My Pushover client is overly chatty right now. Is there an ETA or a release schedule published? Anything I can do to help test?

martomi commented 3 years ago

I'm hoping that enough people were on the dev branch and will take the lack of issues submitted as confirmation that the change is good to go. Release will be out in the next half hour!

guydavis commented 3 years ago

Hi! I bundled in the dev branch of Chiadog to my test release of Machinaris a few days ago. The enhancement from @kanasite is working well. No concerns raised by any of my users on our Discord. Thanks all for the great improvement.

martomi commented 3 years ago

Thanks @guydavis - this feedback really helps!

The release is now out!