martomi / chiadog

A watch dog providing a peace in mind that your Chia farm is running smoothly 24/7.
MIT License
460 stars 123 forks source link

Fix up the Grafana notifier so it's more standard and functions post config-revamp #366

Closed jinnatar closed 1 year ago

jinnatar commented 1 year ago

While not all options actually make sense for it, it's easier to provide them than special case just because no one would actually ever enable them.

NOTE: This does not mean the Grafana notifier actually supports any more events than it does right now. It probably should, but that's out of scope.

@pieterhelsen As the original author of the integration. I'm not actually managing to push the annotations to Grafana no matter how much I try, so could you check that I'm not accidentally changing anything critical here? For example, code comments lead me to believe null would default to global annotations, but -1 is the example value given, so not sure what the truth there is. Also the test doesn't yet support defining those values.