At the same time I tweaked the keep_alive_monitor VCR to be consistent with how I'm proposing the notifier tests would look like.
Hermetic tests bump up coverage significantly and allow more folks to test against previous known behavior of notifiers. For example, if someone did the coversion for the pushcut notifier to hermetic, I still could've tested against it, just not live. :-)
At the same time I tweaked the keep_alive_monitor VCR to be consistent with how I'm proposing the notifier tests would look like.
Hermetic tests bump up coverage significantly and allow more folks to test against previous known behavior of notifiers. For example, if someone did the coversion for the
pushcutnotifier to hermetic, I still could've tested against it, just not live. :-)