Fix quote parsing on XML

martomo / SublimeTextXdebug

Xdebug debugger client for Sublime Text

MIT License

565 stars 89 forks source link

Fix quote parsing on XML #197

Closed gepeixoto closed 5 years ago

gepeixoto commented 5 years ago

This fix an error while parsing quotes in XML returned from Xdebug server

ryanpcmcquen commented 5 years ago

@martomo, can this get merged/released?

ryanpcmcquen commented 5 years ago

@gepeixoto, have you considered merging in all PRs and making your own version for Package Control?

ryanpcmcquen commented 5 years ago

I've merged your fixes into my fork: https://github.com/ryanpcmcquen/SublimeTextXdebugPlus

Which I am attempting to get into Package Control: https://github.com/wbond/package_control_channel/pull/7658

martomo commented 5 years ago

@gepeixoto Thanks for contributing, I've added an exception for quote (and apostrophe) entities in 0b76fe7438bd01cf18469cafdb8032594252fc1b, as alternative to your proposed solution which would actually change &quot (") incorrectly as '(&apos) that resulted in different rendered output from Xdebug response.