search

martomo / SublimeTextXdebug

Xdebug debugger client for Sublime Text
MIT License
564 stars 89 forks source link

Fix breakpoint element protocol to allow continue commands #198

Closed gepeixoto closed 4 years ago

gepeixoto commented 5 years ago

There is an issue where the first breakpoint is not set to "current" and it's not possible to use continue commands.

Confirmed that this happens with Xdebug 2.7.0 (PHP version >= 7.1)

The reason is that the protocol for the breakpoint element should be using "https" instead of "http"

This PR fix this.

Daniel-Yonkov commented 5 years ago

May I fork and test this?

gepeixoto commented 5 years ago

May I fork and test this?

Sure!

Daniel-Yonkov commented 5 years ago

Btw, I see there is some issue with the build of this PR. P.S. Haven't tested it yet

gepeixoto commented 5 years ago

Btw, I see there is some issue with the build of this PR. P.S. Haven't tested it yet

Sorry, I didn't got what do you mean by "there is some issue with the build of this PR".

Daniel-Yonkov commented 5 years ago

For this plugin there is a CI tool used for testing Pull Requests in order to not break the functionality of the plugin. Here you can see the details: https://travis-ci.org/martomo/SublimeTextXdebug I think it maybe due to some configuration on the Build and not your Pull Request, but nevertheless I wanted to make sure that you have seen it and can confirm is due to that

Daniel-Yonkov commented 5 years ago

Confirm it works as expected.

ryanpcmcquen commented 5 years ago

I've merged your fixes into my fork: https://github.com/ryanpcmcquen/SublimeTextXdebugPlus

Which I am attempting to get into Package Control: https://github.com/wbond/package_control_channel/pull/7658

martomo commented 4 years ago

@gepeixoto Thanks for contributing, instead of replacing of http with https I've decided to keep support for older Xdebug versions by checking for both http and https in a4ae19696f48ec4e8f88d95e00ee231b73afa2b3.