Closed gepeixoto closed 4 years ago
May I fork and test this?
May I fork and test this?
Sure!
Btw, I see there is some issue with the build of this PR. P.S. Haven't tested it yet
Btw, I see there is some issue with the build of this PR. P.S. Haven't tested it yet
Sorry, I didn't got what do you mean by "there is some issue with the build of this PR".
For this plugin there is a CI tool used for testing Pull Requests in order to not break the functionality of the plugin. Here you can see the details: https://travis-ci.org/martomo/SublimeTextXdebug I think it maybe due to some configuration on the Build and not your Pull Request, but nevertheless I wanted to make sure that you have seen it and can confirm is due to that
Confirm it works as expected.
I've merged your fixes into my fork: https://github.com/ryanpcmcquen/SublimeTextXdebugPlus
Which I am attempting to get into Package Control: https://github.com/wbond/package_control_channel/pull/7658
@gepeixoto Thanks for contributing, instead of replacing of http with https I've decided to keep support for older Xdebug versions by checking for both http and https in a4ae19696f48ec4e8f88d95e00ee231b73afa2b3.
There is an issue where the first breakpoint is not set to "current" and it's not possible to use continue commands.
Confirmed that this happens with Xdebug 2.7.0 (PHP version >= 7.1)
The reason is that the protocol for the breakpoint element should be using "https" instead of "http"
This PR fix this.