martomo / SublimeTextXdebug

Xdebug debugger client for Sublime Text
MIT License
564 stars 89 forks source link

Two new features #83

Closed sbacic closed 10 years ago

sbacic commented 10 years ago

Added the ability to more easily modify variables during debugging. Also added ability to break on termination - whether regular or forced (exit and die).

martomo commented 10 years ago

Thank you for your contribution, always good to see people trying to help improve the code.

However I do not see the reason of implementing this, seeing you achieve exactly the same by using Xdebug: Session - Evaluate and finishing any session by Xdebug: Stop Debugging without having to configure yet another break_on_end setting.

Besides Xdebug is already complex enough as it has plenty of functions/settings, my goal is to stay as close to the available configurations/functions provided with Xdebug. When we will start adding custom settings or functions it will just escalate at some point and just make this package and perhaps Xdebug harder to use.

sbacic commented 10 years ago

Hello,

thanks for checking out my code. I admit that I'm a little saddened you decided not to include it in your repo but that's okay : ) I've developed these changes primarily for my own personal use because the included solutions simply didn't fulfill my needs. I hope to continue working on it as time permits and my own needs grow and change.

Thank you for such a wonderful plugin!