search

marton-balazs-kovacs / tenzing

tenzing: documening contributorship with CRediT
https://marton-balazs-kovacs.github.io/tenzing/
Other
54 stars 4 forks source link

accept entry without affiliation #60

Open jcolomb opened 3 years ago

jcolomb commented 3 years ago

sometimes only looking at contribution statement, so not needing the affiliation. Change from error to warnings when there is no affiliation

marton-balazs-kovacs commented 3 years ago

You are right! This is a big topic and we should definitely review the validation function. Changes have to be made on several fronts regarding the validation. This is one of them. Another would be being more permissive with the column names. If we want to make affiliations not necessary we have to include a display logic so the outputs that require this info are disabled. I plan to functionalize the display logic part better so it would be easy to change and upgrade them. Let's make this a high priority for the next release.

alexholcombe commented 2 years ago

In conversation today, Marton and I agreed to have the app "degrade gracefullly" with degenerate input, in that it would still provide outputs (as even partial outputs are useful for some use cases, so it can be somewhat irritating to users to refuse to provide an output) in almost all cases but prominently indicate warnings, and indicate missing information with NA or NULL in all-caps, written in red (except for raw-text output which doesn't allow color).