ARM compiler options are wrong

marton78 / pffft

A fork of Julien Pommier's Pretty Fast FFT (PFFFT) library, with several additions

Other

246 stars 57 forks source link

ARM compiler options are wrong #53

Open knell opened 2 years ago

knell commented 2 years ago

16:37:39 [ 8%] Building C object PFFFT/CMakeFiles/PFFFT.dir/pffft_double.c.o 16:37:39 arm-buildroot-linux-gnueabihf-gcc.br_real: error: unrecognized command-line option '-msse2'

Starting from line 170 in CMakeLists.txt there is no check for arm platforms, like this:

elseif(CMAKE_COMPILER_IS_GNUCC AND NOT USE_SIMD_NEON)

marton78 commented 2 years ago

Hi @knell, thank you for the bug report. I don't have time to take care of it, but I'm happy to accept pull requests.

knell commented 2 years ago

Well, the problem is that the -march=native does not work as well, it's not a valid option too. I have fixed it using the particular armv7 architecture but that's not the proper fix in general, of course. It should be some precise platform detection I guess to use that option properly.

hayguen commented 2 years ago

would you please check this again? (after my big changes in the cmake files)