Take postcss dir-dependencies into account

Intrepidd commented 3 years ago

Thanks for this great plugin 🙏

Using tailwind and watch mode, I realised there would not be any rebuild when changing my html files.

This PR is a WIP aiming to add complete PostCSS dependency support to this plugin.

Some gotchas :

No tests yet
At the moment I only take care of dir-dependency, I guess we could also look at regular dependencies and stop passing getFilesRecursive(sourceDir) to watchFiles ?
For dir dependencies, I don't respect the glob pattern and just send every file to the watched files (I think postcss-loader for webpack does the same), mostly for performance reasons and to avoid adding a glob library

WDYT ? I'll be glad to improve this PR and add tests following your guidance

martonlederer commented 3 years ago

Great improvement! Let me know when you feel like it's ready to merge - right now I don't have that much time to check everything in detail

Intrepidd commented 3 years ago

Noted, I will try to submit a ready-to-merge PR soon following the bullet points i mentionned in this PR and using my best judgement

Intrepidd commented 3 years ago

Ok @martonlederer this should be it,

This PR now :

Uses each source postcss file as a dependency
- Plus any dependency or dir-dependency postcss advertises
Has a test for it

Intrepidd commented 2 years ago

Hi @martonlederer, had any chance to look at this ? I'm using it in production for months now and it runs smoothly :)

martonlederer commented 2 years ago

Hey merging it today :)

martonlederer / esbuild-plugin-postcss2