martonlederer / esbuild-plugin-postcss2

Use postcss with esbuild
MIT License
33 stars 19 forks source link

make module file configurable #14 #34

Closed gsouf closed 2 years ago

gsouf commented 2 years ago

Hi,

This will provide a way to replace the default file module detection via a custom callback function. (see readme update).

I added a very simple unit test, but it seems that unit tests are broken and not working. Also note that tests do not seem to test the correctness of the exported css module, that I did not test in my unit test either.

martonlederer commented 2 years ago

Will merge this soon, please tag me in a few days if I forget

gsouf commented 2 years ago

@martonlederer A kind reminder :)

martonlederer commented 2 years ago

Anything you know about why unit tests are broken?

EDIT: my bad, it is broken because of a previous pr, merging and publishing now