search

martonsagi / al-object-designer

AL Object Designer for Dynamics 365 Business Central development
MIT License
40 stars 21 forks source link

Adopt VS Code's 'asWebviewUri' API #65

Closed mjbvz closed 4 years ago

mjbvz commented 4 years ago

Hi, I maintain VS Code's Webview API

Issue

Our telemetry suggests that your extension uses webviews and may be loading resources in these webviews using hardcoded vscode-resource: URIs. These URIs have some important limitations and don't work properly when VS Code is run in a browser. We are also making changes in the desktop version of VS Code that may cause these URIs to not work properly in future versions of VS Code.

While we are making our best effort to continue support existing webview extensions that use vscode-resource: URIs on desktop versions of VS Code, we will not able to fully support all uses cases.

Fix

To ensure that your extension continues to work in as many environments as possible—including on web and remotely—please:

These APIs shipped around 2 years ago so they should be available in all modern versions of VS Code. You can find additional information about the issue here: https://github.com/microsoft/vscode/issues/97962

Let me know if you have any questions about this change

martonsagi commented 4 years ago

Hi Matt,

Thank you for bringing this to my attention. I've updated the affected part and it'll be shipped as part of the next release.

Thanks, Marton