search

martpie / museeks

🎵 A simple, clean and cross-platform music player
https://museeks.io
MIT License
1.71k stars 200 forks source link

Volume bar opens to left of volume icon and covers the play buttons #351

Open giorgosioak opened 7 years ago

giorgosioak commented 7 years ago

The volume bar opens at the left of the volume icon and covers the play buttons until you move the mouse away. Sometimes you want to click pause you move your mouse over the volume icon and you need to make a second move to close the volume bar that pops up. Being on the right side of volume icon makes it more simple.

screenshot from 2017-07-23 13-20-02 screenshot from 2017-07-23 13-21-43

My suggestion is to make it open at the right of the icon 😉

Specs: Museeks 0.8.1 (Installed via AUR) -- OS: Arch Linux -- Kernel: _x8664 Linux 4.11.7-1-ARCH

martpie commented 7 years ago

Hello @giorgosioak, thanks for the suggestion and the usecase problem well detailed. I will try to find a nice solution to this problem :)

martpie commented 7 years ago

Two quick mockups (poke @vprigent, @YurySolovyov). This is more what I had in mind. Just a few CSS tweaks.

screenshot from 2017-09-08 13 50 57

screenshot from 2017-09-08 13 51 41

personal preference for the first one, what do you think?

@vprigent Do you want to work on it?

YurySolovyov commented 7 years ago

Still 1 more interaction (click/hover) than needed.

YurySolovyov commented 7 years ago

One possibility I see is to rework header in a way that will allow us to place volume control below or above the playback controls

martpie commented 7 years ago

One requirement that I have is: "in a 1920*1080 screen, Museeks minimum width should not exceed half of the screen width".

Having a look at @giorgosioak problem, it's just he cannot adjust volume then directly click an play/pause. It's not really that he has to hover the volume to show VolumeControl. Or am I wrong?

giorgosioak commented 7 years ago

@KeitIG Correct

martpie commented 6 years ago

A bit unrelated, but it could be solved in the same issue. From #423 by @lottanbettan

a short delay (0.2 sec?) on hoover (volume button and timeline bar), would fix the "flickering" appearance.

vprigent commented 6 years ago

Wow, I missed a lot of things here. A popup for the sound bar does not feel "good". My PR is probably outdated and the solution was not ideal anyway.

423 is more promising

AntiGuide commented 4 years ago

509 seems like a good solution. Why isn't this getting merged?