martpie / museeks

🎵 A simple, clean and cross-platform music player
https://museeks.io
MIT License
1.71k stars 200 forks source link

Capture logs while initializing plugins #749

Closed uklotzde closed 8 months ago

martpie commented 8 months ago

Thanks for that, I was wondering why logging was not working in plugins.

Let me create an official tauri branch for all that, and we can start merging things there (I use stacked diffs for #748, so I'm basically force-pushing all the time).

The branch is still missing a few critical pieces, but I can create new PRs for these

martpie commented 8 months ago

(bis) Due to force-pushes, I think there are conflicts here. Could you maybe just rebase on top tauri and ignore aa1b762 ?

Sorry, that's due to me using Sapling SCM for managing my work, and it does not work well in a collaborative environment with GitHub.

martpie commented 8 months ago

Thank you! I am not a Rust person, so you will see a lot of non-idiomatic Rust in the current wip codebase for Tauri ;)