[Tauri][wip] Fix theme integration - Githubissues

martpie / museeks

🎵 A simple, clean and cross-platform music player

https://museeks.io

MIT License

1.71k stars 200 forks source link

[Tauri][wip] Fix theme integration #759

Closed martpie closed 2 weeks ago

martpie commented 8 months ago

do not merge. not ready. code sucks. the whole process sucks. I have to draw a flow chart from scratch.

I need to move that code to a single-direction-data-flow.

What we need to reimplement:

[ ] Museeks 0.13 behavior, but for Tauri
- [x] "System" theme
- [x] Window theme is correctly set (already done by Tauri, when theme is None)
  - [ ] [hard] While making explicit light/dark initial window theme work
- [x] Update theme based on the ThemeChanged event
- [ ] "Dark" or "Light" theme
- [ ] Set dark/light window theme on startup
- [ ] Set dark/light app content theme on startup
- [ ] [hard] Update window theme at runtime when user selects a new theme

martpie commented 2 weeks ago

Actually already fixed