search

martsberger / django-pivot

A module for pivoting Django Querysets
MIT License
210 stars 16 forks source link

Django3 compatible fixes #12 #13

Closed osvill closed 3 years ago

osvill commented 4 years ago

Updated travis.yml for Django 3.0 support Updated utils.py for Django 3.0 support Updated tests/pivot/test.py for Django 3.0 support

codecov-io commented 4 years ago

Codecov Report

Merging #13 into master will decrease coverage by 1.89%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
- Coverage      99%   97.11%   -1.9%     
=========================================
  Files           3        3             
  Lines         101      104      +3     
=========================================
+ Hits          100      101      +1     
- Misses          1        3      +2
Impacted Files Coverage Δ
django_pivot/utils.py 92.1% <60%> (-5.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 256a928...f5bdace. Read the comment docs.

osvill commented 4 years ago

I looked into an older version of django (2.1.7) and there the method force_str is kind of mapped to force_text. So we can import only force_str. I ran travis without errors with this new adjustment. What do you think?