martsberger / django-pivot

A module for pivoting Django Querysets
MIT License
209 stars 16 forks source link

Fix for issue #26. Column aliases containing spaces cause an error. #27

Closed martsberger closed 11 months ago

martsberger commented 11 months ago

Since column aliases in annotations are now restricted to not have whitespace, sql comments, quotes, or semicolons, they are aliased during the SQL query, and returned back after the query returns.

Test data has been updated so that each of the disallowed characters is used.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% :tada:

Comparison is base (3cb4603) 99.05% compared to head (5410b7a) 99.20%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #27 +/- ## ========================================== + Coverage 99.05% 99.20% +0.14% ========================================== Files 3 4 +1 Lines 106 126 +20 ========================================== + Hits 105 125 +20 Misses 1 1 ``` | [Files Changed](https://app.codecov.io/gh/martsberger/django-pivot/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=B+Martsberger) | Coverage Δ | | |---|---|---| | [django\_pivot/tests/pivot/models.py](https://app.codecov.io/gh/martsberger/django-pivot/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=B+Martsberger#diff-ZGphbmdvX3Bpdm90L3Rlc3RzL3Bpdm90L21vZGVscy5weQ==) | `100.00% <ø> (ø)` | | | [django\_pivot/pivot.py](https://app.codecov.io/gh/martsberger/django-pivot/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=B+Martsberger#diff-ZGphbmdvX3Bpdm90L3Bpdm90LnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.