search

martskins / vim-cargo-search

MIT License
3 stars 1 forks source link

Too many arguments for function: cs#CrateSelected #1

Closed GopherJ closed 4 years ago

GopherJ commented 4 years ago

Hi, thanks for making this plugin, I had this error after hitted enter:

image

This error doesn't happen in neovim0.4.3 just in vim8.2

GopherJ commented 4 years ago

Also I didn't find a way to cancel it

martskins commented 4 years ago

Thank you for reporting this! It seems like I misunderstood how popup_menu works in vim.

Just pushed a fix for this, so if you update it should be working for you. Do let me know if anything else comes up.

GopherJ commented 4 years ago

@martskins It starts to work in vim. thanks, how can we cancel it if I don't find what I want?

martskins commented 4 years ago

<ESC> should close the popup without moving to Cargo.toml.

GopherJ commented 4 years ago

Another point is, if we can using CTRL+J and CTRL+K to switch between items, it'll be great

GopherJ commented 4 years ago

@martskins

should close the popup without moving to Cargo.toml.

Just tried in vim it still goes to Cargo.toml, but yes in neovim it works

martskins commented 4 years ago

Just tried in vim it still goes to Cargo.toml

Ah yeah, sorry, this works in neovim. I didn't handle this correctly in vim. Pushing a fix for that now.

GopherJ commented 4 years ago

@martskins Great, thanks! It's really useful to have this tool in (neo)vim!