search

martukas / nuclei

An Evaluated Nuclear Structure Data (ENSDF) parser, viewer and editor
GNU General Public License v3.0
20 stars 6 forks source link

Specify the build type in the conan command #21

Closed php1ic closed 8 months ago

php1ic commented 9 months ago

Start working on #20

We should also update the CI to do Debug and Release builds

php1ic commented 9 months ago

Is the ci/circleci: build-run check hard coded? If so, it will need to be changed or removed now the different Debug and Release CI builds have been added.

ferdymercury commented 9 months ago

Thanks, debug build works now!

@martukas might know wrt build-run

ferdymercury commented 9 months ago

@php1ic maybe you need to set the default build type? See https://discuss.circleci.com/t/using-pipeline-parameters/34980/8

php1ic commented 9 months ago

Any preference on the default build type?

ferdymercury commented 9 months ago

Any preference on the default build type?

Release I'd say

ferdymercury commented 9 months ago

Thanks! Hmm it seems there is still the build-run thing without suffix. Maybe it does not like having this "matrix" parameter?

php1ic commented 9 months ago

Some searching suggests that "expected" checks are setup and configured by someone with push access to the branch

https://stackoverflow.com/questions/39043691/github-pull-request-checks https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches

Can you see anything in Settings->Branches for this repo?

ferdymercury commented 9 months ago

Can you see anything in Settings->Branches for this repo?

Nope. I only have access to Settings tab. So I guess we need @martukas assistance.