search

marty-suzuki / SAHistoryNavigationViewController

SAHistoryNavigationViewController realizes iOS task manager like UI in UINavigationContoller. Support 3D Touch!
MIT License
1.57k stars 91 forks source link

Some desired changes #26

Closed ayushgoel closed 8 years ago

ayushgoel commented 8 years ago

The code here:

  1. Solves the bug where the SAHistoryNavigationViewController extends behind status bar if a modal UIViewController is presented.
  2. Removes any custom animation and works purely by following the delegate methods. (IMHO, the animation should be a different pod altogether)
  3. Uses some functional constructs where it makes understanding code easier.
  4. Extends Sample to present a UIViewController modally.

Some of these changes might be in conflict with what you had planned for this pod. In that case, I would like to create a different pod from this. Also, if you have any suggestions for the code which could make this merge, would love to know them. :innocent:

marty-suzuki commented 8 years ago

Hi @ayushgoel Sorry for late merging. Thank you for your pull request!!

ayushgoel commented 8 years ago

:+1: When do you plan to do a release for this? :smiley:

marty-suzuki commented 8 years ago

i'll release during this week!

marty-suzuki commented 8 years ago

released 2.1.0

ayushgoel commented 8 years ago

:cool: