marty-suzuki / URLEmbeddedView

URLEmbeddedView automatically caches the object that is confirmed the Open Graph Protocol.
MIT License
650 stars 71 forks source link

unable to use it in Objective C project #36

Closed github-prathma closed 7 years ago

github-prathma commented 7 years ago

Tried using it in objective C, even after adding use_frameworks! in podfile, It seems use_frameworks! doesn't work and also tried to add it manually in share extension of my app, but files in URLEmbeddedView source like OGDataProvider unable to access Kanna and Misterfusion files embedded in this pod source, even after adding Kanna and Misterfusion seperately using git clone.

marty-suzuki commented 7 years ago

Hi @github-prathma

I've tried to use URLEmbeddedView in Objective-C, and it works fine without any errors.

2017-08-16 19 07 05 2017-08-16 19 09 48
github-prathma commented 7 years ago

Its not working when using it with other Objective C pods

github-prathma commented 7 years ago

And try using it in extension of main app. It won't work as Extension-Swift.h file will not generate

marty-suzuki commented 7 years ago

URLEmbeddedView is written in Swift therefore, must add use_frameworks!. Doesn't it work that importing other Objective-C pods with #import <libname/libname-Swift.h>?

github-prathma commented 7 years ago

No it doesn't work with that as it shows libname-Swift.h as file not found

On Wed, 16 Aug 2017 at 6:39 PM, Taiki Suzuki notifications@github.com wrote:

URLEmbeddedView is written in Swift therefore, must add use_frameworks!. Doesn't it work that importing other Objective-C pods with '#import <libname/libname-Swift.h>'?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marty-suzuki/URLEmbeddedView/issues/36#issuecomment-322765559, or mute the thread https://github.com/notifications/unsubscribe-auth/AHRNFjxJ71cJGKMfNbYAHQgsjCGUNvDEks5sYuoYgaJpZM4O4ogE .

marty-suzuki commented 7 years ago

It works in my development environment. This sample uses SDWebImage that written in Objective-C.

2017-08-16 22 30 00 2017-08-16 22 30 14
github-prathma commented 7 years ago

I am using the deployment target as 8.0 . Tell me if this causes a problem. And in my case use_frameworks is causing problem for libraries such as AFNetworking, hakawai, mixpanel

On Wed, 16 Aug 2017 at 7:03 PM, Taiki Suzuki notifications@github.com wrote:

It works in my development environment. This sample uses SDWebImage that written in Objective-C.

[image: 2017-08-16 22 30 00] https://user-images.githubusercontent.com/2082134/29365575-7690e372-82d2-11e7-8a4b-affa48bf6fe0.png

[image: 2017-08-16 22 30 14] https://user-images.githubusercontent.com/2082134/29365592-82b39c4e-82d2-11e7-82c8-2c55e6533ef4.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marty-suzuki/URLEmbeddedView/issues/36#issuecomment-322772026, or mute the thread https://github.com/notifications/unsubscribe-auth/AHRNFkswmTgWgZG7pOo3KfYMMGS2LtmOks5sYu-KgaJpZM4O4ogE .

marty-suzuki commented 7 years ago

I can import them like this (development target iOS 8.0).

2017-08-16 23 00 40 2017-08-16 23 00 54

Dose your XXX-Bridging-Header.h have circular references of framework importing? Please check it.

I can not exactly respond because I could not grasp some problems that your project have. Sorry

github-prathma commented 7 years ago

No, I am not having circular references in my extension as I don't require objective C file to be imported in Swift files but the opposite is required.

So there is a pod file I am having in my project, which contains more than one,

So there is mainApp target, and notificationService extension target, share extension target

So in Share extension target I want to use this library URLEmbeddedView. And right now this extension already supports Hakawai, AFNetworking, Mixpanel-AppExtension, JSONModel etc. pods which are not running and not only this, the error regarding UIApplication.shared.keyWindow is coming in UIView extension code of Misterfusion.swift file as UIApplication can't be used in share extension.

Hereby attaching my Podfile for more reference,

Thanks.

PFA

On Wed, Aug 16, 2017 at 7:41 PM, Taiki Suzuki notifications@github.com wrote:

I can import them like this (development target iOS 8.0).

[image: 2017-08-16 23 00 40] https://user-images.githubusercontent.com/2082134/29367115-d225c186-82d6-11e7-9e44-57a6863febb5.png

[image: 2017-08-16 23 00 54] https://user-images.githubusercontent.com/2082134/29367121-d7dc94f6-82d6-11e7-8424-872714278ca1.png

Dose your XXX-Bridging-Header.h have circular references of framework importing? Please check it.

I can not exactly respond because I could not grasp some problems that your project have. Sorry

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marty-suzuki/URLEmbeddedView/issues/36#issuecomment-322784127, or mute the thread https://github.com/notifications/unsubscribe-auth/AHRNFnr2tv23DxR7tm4hlOSW_wRd9tqQks5sYvilgaJpZM4O4ogE .

{\rtf1\ansi\ansicpg1252\cocoartf1504\cocoasubrtf760 {\fonttbl\f0\fswiss\fcharset0 Helvetica;} {\colortbl;\red255\green255\blue255;} {*\expandedcolortbl;;} \margl1440\margr1440\vieww10800\viewh8400\viewkind0 \pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0

\f0\fs24 \cf0 # Uncomment this line to define a global platform for your project\ platform :ios, '8.0'\ use_frameworks!\ \ def shared_pods\ pod 'VIMVideoPlayer'\ pod 'AFNetworkActivityLogger', :git => 'https://github.com/AFNetworking/AFNetworkActivityLogger.git', :branch => '3_0_0'\ pod 'TLTagsControl', :git => 'https://github.com/ali312/TLTagsControl'\ pod 'FLEX', '~> 2.0', :configurations => ['Debug']\ pod 'GoogleIDFASupport'\ pod 'JSONModel'\ pod 'TLYShyNavBar'\ pod 'SlackTextViewController'\ pod "youtube-ios-player-helper",:git => 'https://github.com/youtube/youtube-ios-player-helper'\ pod 'NYTPhotoViewer'\ pod 'DZNWebViewController'\ pod 'Branch'\ pod 'CSNotificationView'\ pod 'Google/Analytics'\ pod 'FBSDKCoreKit'\ pod 'FBSDKLoginKit'\ pod 'FBSDKShareKit'\ pod 'LoremIpsum', '~> 1.0'\ pod 'Masonry'\ pod "SKTagView"\ pod "PWProgressView"\ pod "AFNetworking"\ pod 'SDWebImage', '~>3.7'\ pod 'SDWebImage/WebP', '~>3.7'\ pod 'Lockbox'\ pod 'IDMPhotoBrowser'\ pod 'DZNPhotoPickerController/Editor'\ pod "SRMonthPicker"\ pod "TPKeyboardAvoiding"\ pod 'Mixpanel'\ pod 'SVProgressHUD'\ pod "CCMPopup"\ pod 'pop', '~> 1.0'\ pod 'FLAnimatedImage' , '~> 1.0'\ pod "TSMessages"\ pod 'Harpy'\ pod "SCLAlertView-Objective-C"\ pod 'AMPopTip'\ pod 'Firebase/Core'\ pod 'Firebase/Analytics'\ pod 'Firebase/Database'\ pod 'Firebase/Auth'\ pod 'Firebase/RemoteConfig'\ pod 'vfrReader',:git => 'https://github.com/vfr/Reader.git' \ pod 'PINCache'\ pod 'SimulatorRemoteNotifications', '~> 0.0.3'\ end\ \ target 'Curofy' do\ shared_pods\ end\ \ target 'CurofyStaging' do\ shared_pods\ end\ \ \ target 'notificationService' do\ pod "AFNetworking"\ pod "Mixpanel/AppExtension"\ pod \'91URLEmbeddedView\'92\ \ post_install do |installer_representation|\ installer_representation.pods_project.targets.each do |target|\ if target.name == "Pods-notificationService-AFNetworking" # EMToday should be the Extension target name\ target.build_configurations.each do |config|\ config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', 'AF_APP_EXTENSIONS=1']\ end\ end\ end\ end\ end\ \ }

marty-suzuki commented 7 years ago

I've used NSLayoutConstraint instead of MisterFusion since 0.10.0 Please try latest version.

github-prathma commented 7 years ago

Sorry I didn't get it .. Latest version of what MisterFusion or NSLayoutConstraint?

On Thu, Aug 17, 2017 at 10:07 PM, Taiki Suzuki notifications@github.com wrote:

I've used NSLayoutConstraint instead of MisterFusion since 0.10.0 Please try latest version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marty-suzuki/URLEmbeddedView/issues/36#issuecomment-323127307, or mute the thread https://github.com/notifications/unsubscribe-auth/AHRNFlQfssKHqfKoo__tv-oBFicMakSoks5sZGxcgaJpZM4O4ogE .

marty-suzuki commented 7 years ago

NSLayoutConstraint is used instead of MisterFusion in URLEmbeddedView since 0.10.0 0.10.0 is latest version of URLEmbeddedView.