search

martyjs / marty

A Javascript library for state management in React applications
http://martyjs.org
MIT License
1.09k stars 76 forks source link

Upgrade React's peer dependency to 0.13.0 #187

Closed dariocravero closed 9 years ago

jhollingworth commented 9 years ago

:+1:

scottcorgan commented 9 years ago

Any reason this wouldn't work with React 0.14?

taion commented 9 years ago

There would be deprecation warnings from not going through ReactDOM for the rendering - not sure if that matters to you.

scottcorgan commented 9 years ago

Warnings aren't as important as the installation error I see with unresolved peerDependencies from NPM.

Where in Marty does it Call render()?

taion commented 9 years ago

Application.renderToString and related methods.

scottcorgan commented 9 years ago

It looks like renderToString() takes a render argument.

Seems possible to pass in from react-dom.

I'm not to familiar with then inner workings of marty and marty-lib, but Perhaps it would be helpful to cut a final 1.0 with support for React 0.14.

In order to avoid this peerDependency issue.