martykan / forecastie

A simple, opensource weather app for Android.
Other
873 stars 339 forks source link

Show sunrise and sunset times on weather graphs #351

Open autofreak opened 5 years ago

autofreak commented 5 years ago

Enable share button without having to screenshot my screen, this will be useful if I want to share weather forecast of my location on social media.

Include intro page, this will go a long way in helping users who are not tech savvy and allow them to set their foot on Forecastie.

As part of graphs, you can include information about sunrise and sunset of the next 5-days as well.

robinpaulson commented 5 years ago

Breaking these down into three:

  1. I doubt it. I would need a lot of convincing to see this as useful. It's trivial to go to OWM and post the forecast directly from the web page.
  2. Yes, I completely agree, I recall someone asked for a FAQ before, I think the two ideas can be merged into one; we show the into page at first use/on upgrade, then add an entry on the menu to access it later as a help page. #281
  3. At first I thought yes, but then I realised the current way we provide information (i.e. sunrise and sunset for today only) is probably good enough. Even at the highest latitudes, I would be surprised if sunrise/sunset changed by more than a couple of minutes per day. Knowing today's values means a user can make a good guess at what tomorrow's values will be (i.e. very close). I'm loathe to add more information to the graphs, this would clutter them and reduce their usefulness while adding little.
robinpaulson commented 5 years ago

Perhaps you would be willing to submit some text for the FAQ/intro? It appears the original requester has lost interest; it's been over a year now since they asked. Pasting it here is fine if you're not willing or able to code.

autofreak commented 5 years ago

Why not?

I consider it as a privilege. Can I create it right now? Or when?

On Fri, 24 May 2019, 5:15 AM robinpaulson, notifications@github.com wrote:

Perhaps you would be willing to submit some text for the FAQ/intro? It appears the original requester has lost interest; it's been over a year now since they asked. Pasting it here is fine if you're not willing or able to code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/martykan/forecastie/issues/351?email_source=notifications&email_token=ALEMAWGZQQ6L322LN4OTTM3PW5TXFA5CNFSM4HOSQ7S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWEDOXA#issuecomment-495466332, or mute the thread https://github.com/notifications/unsubscribe-auth/ALEMAWCW5LWVE4K2B5AMUKLPW5TXFANCNFSM4HOSQ7SQ .

ghost commented 5 years ago

hi guys, this is my first comment on GitHub, i don't know if i wrong for comment here or i need to write my own, ok, a thing would be great is an option for change the widget color in transparent mode because sometimes the wallpaper is white and the weather is difficult to read, thanks a lot for your time

robinpaulson commented 5 years ago

Closing, part duplicate of #281, part "Won't fix".

robinpaulson commented 4 years ago

I'm going to reopen this, as I realised I misunderstood the part about sunrise and sunset. I assumed the important part of this was the variation of these times over the next few days. I realise now what you wanted to do was show information on the graph concerning when the weather changed in relation to the sun times.

robinpaulson commented 4 years ago

Once the improved graphs from #331 are settled, perhaps we think about including it? My position on the "share" button hasn't changed. I am still keen to see an intro/help/FAQ page.

robinpaulson commented 4 years ago

@autofreak does this appeal still, have i understood it better?

autofreak commented 4 years ago

Yes, you did.

On Sat, 30 Nov 2019, 11:53 AM robinpaulson, notifications@github.com wrote:

@autofreak https://github.com/autofreak does this appeal still, have i understood it better?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/martykan/forecastie/issues/351?email_source=notifications&email_token=ALEMAWBCEECWJ7KTRNHXN53QWJA4NA5CNFSM4HOSQ7S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQB2DQ#issuecomment-559947022, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEMAWFVHIDMJTSOKT4TFALQWJA4NANCNFSM4HOSQ7SQ .

robinpaulson commented 4 years ago

On my phone (a Galaxy S3), the bar for each day is 9mm wide. If we put the sunset and sunrise times in, this will split that block into tree pieces (midnight - sunrise, sunrise - sunset, sunset - midnight), each of which will vary in width through the year. They will be the order of 1.5-4mm wide each. I think we need a mockup at the very least, to see if this is viable. @autofreak are you prepared to do this? It doesn't have to use the dimensions for my phone, but how it looks on something small-medium size would be useful. We should probably consider extremes of latitude, even in Auckland where I live the sunset - midnight time is only 3 hours long (1/8 of the total day length).

robinpaulson commented 4 years ago

Based on offline feedback from a user, I've opened an issue (#446) which affects this issue. If, as I suggest, we create an option to display 1 or 2 days only on the graphs, that makes this issue more interesting and useful for those with ordinary smartphone screens.