search

martykan / forecastie

A simple, opensource weather app for Android.
Other
871 stars 338 forks source link

Blue "Fresh" icon #597

Closed julianfairfax closed 3 years ago

julianfairfax commented 3 years ago

This pull request changes the launcher icon to match the default blue "Fresh" theme, resolving #596

robinpaulson commented 3 years ago

Ah, I thought this was going to make the icon dynamic, so it automatically followed the selected colour scheme of the software?

robinpaulson commented 3 years ago

If it did that, I would accept it. but not as it is.

julianfairfax commented 3 years ago

That would be the best solution but I haven't the slightest idea how to implement it.

julianfairfax commented 3 years ago

It doesn't make sense to use a different primary color in the icon than in the default theme in any case. That and grey colors in a weather app invoke cloudy, depressing weather rather than blue, joyful, sky. I suspect most weather apps use blue as their primary color for this reason.

robinpaulson commented 3 years ago

Eh, there's a good reason for every colour to be used for the icon/theme.

robinpaulson commented 3 years ago

I'm not convinced by the other arguments either.

julianfairfax commented 3 years ago

Eh, there's a good reason for every colour to be used for the icon/theme.

I'm just saying it would make sense for the same colour to be used for the icon and theme.

julianfairfax commented 3 years ago

I'm not convinced by the other arguments either.

Well you're perfectly right in not being convinced if you don't view it that way, but most weather apps do seem to have a design gravitating more to blue than to grey. So this would make sense for your app if only even to just make it's purpose more clear.

julianfairfax commented 3 years ago

Ah, I thought this was going to make the icon dynamic, so it automatically followed the selected colour scheme of the software?

I don't think this is actually possible but it would be the ideal method. The question then just is if it makes sense having a grey icon and a blue default theme. But I suppose that also doesn't necessarily mean it's the icon that needs to be changed. (Also the splash screen seems to be grey regardless of the theme set).

julianfairfax commented 3 years ago

If it did that, I would accept it. but not as it is.

I will close it