search

martykan / forecastie

A simple, opensource weather app for Android.
Other
868 stars 335 forks source link

fix and add notification korean #616

Closed BAESI closed 2 years ago

BAESI commented 2 years ago

I fix unit beacause Korean peoples use units in English and not in Korean. and I translated and added the notification.

robinpaulson commented 2 years ago

Great! I looked back through the commit history, it appears another Korea-based student added the original translation almost exactly two years ago. I wonder if they were at the same university as you?

BAESI commented 2 years ago

She is my friend and colleague. I've been in the military for two years, so I'm taking a later class. I didn't know she contributed to this app.

robinpaulson commented 2 years ago

Hi, we had some problems which I reverted by doing a git reset, meaning we also lost your code. I'm afraid my git skills aren't that great, would you be able to re-propose this and I'll merge it in a couple of days? Thanks

BAESI commented 2 years ago

Hi! I'm working on another project right now, but I don't have much time left, so I think I'll have time over the weekend. Will that be okay? if you okay, Should I do full request for Korean translation and UVindex fix?

robinpaulson commented 2 years ago

Hi, sorry @BAESI I forgot about this. It would be much appreciated if you could do the UVindex fix and the Korean translation fix. Cheers!