search

martykan / forecastie

A simple, opensource weather app for Android.
Other
868 stars 335 forks source link

Add support for percent of precipitation #627

Closed shortspider closed 2 years ago

shortspider commented 2 years ago

Fixes #79.

robinpaulson commented 2 years ago

Hi @shortspider this is great, I'm pleased to see this. How does it display, I couldn't work it out from looking at the code?

Also, I think the phrase "percent of precipitation" could be better, perhaps "chance of precipitation"?

shortspider commented 2 years ago

@robinpaulson I've renamed to chance. Here is a screenshot from the emulator: image

robinpaulson commented 2 years ago

Excellent, thanks for that! I see why you chose the original variable name now, OWM calls it "pop".

robinpaulson commented 2 years ago

@shortspider I had to do a git reset today, after another coder broke the GUI with a bad commit. Could you re-propose this for merge? My git fu is not so great and I fear my brain can't take learning how to do it all from this end.

shortspider commented 2 years ago

@robinpaulson it looks like all the code is still there: image`

robinpaulson commented 2 years ago

Hi, yes, I made (another) mistake. After doing the hard reset, I remerged your contribution, not realising it would pull in a series of other commits which were the cause of the app breaking. I've since done another hard reset to remove the breaking code again, which has also removed your commits. I need to learn more about Git, there's lots I don't understand.

shortspider commented 2 years ago

@robinpaulson I've had to create a new PR, please review #631.