search

martykan / forecastie

A simple, opensource weather app for Android.
Other
868 stars 335 forks source link

Add support for chance of precipitation #631

Closed shortspider closed 2 years ago

shortspider commented 2 years ago

Need a new PR after #627 was removed.

robinpaulson commented 2 years ago

Thanks! As soon as I see v1.20 is working OK, I'll merge this.

robinpaulson commented 2 years ago

Much appreciated, I'll put out a new release in a week or so.

robinpaulson commented 2 years ago

The code didn't build after I added your PR, I wonder if you could take a look? I suspect it is a trivial failure we can ignore, but want to be sure.

robinpaulson commented 2 years ago

@igor-cali Do you recall how we were getting build errors the first time you submitted Spanish and Italian translations about two weeks ago? It appears we are getting the same errors again, from a different PR.

shortspider commented 2 years ago

@robinpaulson I just checked out the latest code and it builds fine for me. I'm just hitting make in android studio, are you doing something different?

robinpaulson commented 2 years ago

./gradlew build

Is the command in the github action to build it. It's a unit test failing, but I don't know why

robinpaulson commented 2 years ago

@shortspider I discovered a minor bug today in the code for this, could you take a look? See attached

Screenshot_20220106-175618_Forecastie